Merge pull request #644 from CesiumGS/maintenance

Monthly Maintenance
CesiumGS · Oct 3, 2023 · fe2b2c1 · fe2b2c1
2 parents 8121433 + 575c05f
commit fe2b2c1
Show file tree

Hide file tree

Showing 45 changed files with 315 additions and 308 deletions.
diff --git a/bin/gltf-pipeline.js b/bin/gltf-pipeline.js
@@ -171,7 +171,7 @@ if (!defined(outputPath)) {
   }
   outputPath = path.join(
     inputDirectory,
-    `${inputName}-processed${outputExtension}`
+    `${inputName}-processed${outputExtension}`,
   );
 }
 
@@ -255,5 +255,5 @@ read(inputPath)
   })
   .catch(function (error) {
     console.log(error);
-    process.exit(1);
+    process.exitCode = 1;
   });
diff --git a/gulpfile.js b/gulpfile.js
@@ -47,7 +47,7 @@ async function test() {
     new JasmineSpecReporter({
       displaySuccessfulSpec:
         !defined(argv.suppressPassed) || !argv.suppressPassed,
-    })
+    }),
   );
 
   jasmine.exitOnCompletion = false;
@@ -83,7 +83,7 @@ function coverage() {
       " JASMINE_CONFIG_PATH=specs/jasmine.json",
     {
       stdio: [process.stdin, process.stdout, process.stderr],
-    }
+    },
   );
 
   return Promise.resolve();
@@ -172,7 +172,7 @@ function amdify(source, subDependencyMapping) {
         const mapping = subDependencyMapping[requirePath];
         if (!defined(mapping)) {
           throw new Error(
-            `Build Failed: Module sub-dependency found for ${requirePath} with no defined mapping behavior.`
+            `Build Failed: Module sub-dependency found for ${requirePath} with no defined mapping behavior.`,
           );
         }
         removeRequireMapping.push(requireVariable);
@@ -196,7 +196,7 @@ function amdify(source, subDependencyMapping) {
     if (
       Object.prototype.hasOwnProperty.call(
         subdependencyMapping,
-        subdependencyVariable
+        subdependencyVariable,
       )
     ) {
       requireMapping[subdependencyVariable] =
@@ -335,7 +335,7 @@ async function generateThirdParty() {
   for (const packageName in dependencies) {
     if (dependencies.hasOwnProperty(packageName)) {
       const override = thirdPartyExtraJson.find(
-        (entry) => entry.name === packageName
+        (entry) => entry.name === packageName,
       );
       thirdPartyJson.push(getLicenseDataFromPackage(packageName, override));
     }
@@ -355,6 +355,6 @@ async function generateThirdParty() {
 
   fsExtra.writeFileSync(
     "ThirdParty.json",
-    JSON.stringify(thirdPartyJson, null, 2)
+    JSON.stringify(thirdPartyJson, null, 2),
   );
 }
diff --git a/lib/FileUrl.js b/lib/FileUrl.js
@@ -84,7 +84,7 @@ function getPathFromURLWin32(url) {
       ) {
         // 5c 5C \
         throw new RuntimeError(
-          "file URL must not include encoded \\ or / characters"
+          "file URL must not include encoded \\ or / characters",
         );
       }
     }
@@ -124,7 +124,7 @@ function getPathFromURLPosix(url) {
       const third = pathname.codePointAt(n + 2) | 0x20;
       if (pathname[n + 1] === "2" && third === 102) {
         throw new RuntimeError(
-          "file URL must not include encoded \\ or / characters"
+          "file URL must not include encoded \\ or / characters",
         );
       }
     }

diff --git a/lib/ForEach.js b/lib/ForEach.js
@@ -85,7 +85,7 @@ ForEach.accessorWithSemantic = function (gltf, semantic, handler) {
               return value;
             }
           }
-        }
+        },
       );
 
       if (defined(valueForEach)) {
@@ -107,7 +107,7 @@ ForEach.accessorWithSemantic = function (gltf, semantic, handler) {
                 return value;
               }
             }
-          }
+          },
         );
       });
     });
@@ -129,7 +129,7 @@ ForEach.accessorContainingVertexAttributeData = function (gltf, handler) {
               return value;
             }
           }
-        }
+        },
       );
 
       if (defined(valueForEach)) {
@@ -148,7 +148,7 @@ ForEach.accessorContainingVertexAttributeData = function (gltf, handler) {
                 return value;
               }
             }
-          }
+          },
         );
       });
     });
@@ -327,7 +327,7 @@ ForEach.program = function (gltf, handler) {
   if (usesExtension(gltf, "KHR_techniques_webgl")) {
     return ForEach.object(
       gltf.extensions.KHR_techniques_webgl.programs,
-      handler
+      handler,
     );
   }
 
@@ -346,7 +346,7 @@ ForEach.shader = function (gltf, handler) {
   if (usesExtension(gltf, "KHR_techniques_webgl")) {
     return ForEach.object(
       gltf.extensions.KHR_techniques_webgl.shaders,
-      handler
+      handler,
     );
   }
 
@@ -415,7 +415,7 @@ ForEach.technique = function (gltf, handler) {
   if (usesExtension(gltf, "KHR_techniques_webgl")) {
     return ForEach.object(
       gltf.extensions.KHR_techniques_webgl.techniques,
-      handler
+      handler,
     );
   }
 

diff --git a/lib/addDefaults.js b/lib/addDefaults.js
@@ -69,7 +69,7 @@ function addDefaults(gltf) {
   ForEach.material(gltf, function (material) {
     const extensions = defaultValue(
       material.extensions,
-      defaultValue.EMPTY_OBJECT
+      defaultValue.EMPTY_OBJECT,
     );
     const materialsCommon = extensions.KHR_materials_common;
     if (defined(materialsCommon)) {
@@ -103,19 +103,19 @@ function addDefaults(gltf) {
       // These actually exist on the extension object, not the values object despite what's shown in the spec
       materialsCommon.transparent = defaultValue(
         materialsCommon.transparent,
-        false
+        false,
       );
       materialsCommon.doubleSided = defaultValue(
         materialsCommon.doubleSided,
-        false
+        false,
       );
 
       return;
     }
 
     material.emissiveFactor = defaultValue(
       material.emissiveFactor,
-      [0.0, 0.0, 0.0]
+      [0.0, 0.0, 0.0],
     );
     material.alphaMode = defaultValue(material.alphaMode, "OPAQUE");
     material.doubleSided = defaultValue(material.doubleSided, false);
@@ -142,15 +142,15 @@ function addDefaults(gltf) {
     if (defined(pbrMetallicRoughness)) {
       pbrMetallicRoughness.baseColorFactor = defaultValue(
         pbrMetallicRoughness.baseColorFactor,
-        [1.0, 1.0, 1.0, 1.0]
+        [1.0, 1.0, 1.0, 1.0],
       );
       pbrMetallicRoughness.metallicFactor = defaultValue(
         pbrMetallicRoughness.metallicFactor,
-        1.0
+        1.0,
       );
       pbrMetallicRoughness.roughnessFactor = defaultValue(
         pbrMetallicRoughness.roughnessFactor,
-        1.0
+        1.0,
       );
       addTextureDefaults(pbrMetallicRoughness.baseColorTexture);
       addTextureDefaults(pbrMetallicRoughness.metallicRoughnessTexture);
@@ -161,15 +161,15 @@ function addDefaults(gltf) {
     if (defined(pbrSpecularGlossiness)) {
       pbrSpecularGlossiness.diffuseFactor = defaultValue(
         pbrSpecularGlossiness.diffuseFactor,
-        [1.0, 1.0, 1.0, 1.0]
+        [1.0, 1.0, 1.0, 1.0],
       );
       pbrSpecularGlossiness.specularFactor = defaultValue(
         pbrSpecularGlossiness.specularFactor,
-        [1.0, 1.0, 1.0]
+        [1.0, 1.0, 1.0],
       );
       pbrSpecularGlossiness.glossinessFactor = defaultValue(
         pbrSpecularGlossiness.glossinessFactor,
-        1.0
+        1.0,
       );
       addTextureDefaults(pbrSpecularGlossiness.specularGlossinessTexture);
     }
@@ -199,7 +199,7 @@ function addDefaults(gltf) {
         [
           1.0, 0.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0,
           0.0, 1.0,
-        ]
+        ],
       );
     }
   });