Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing mapping with # in the file name. #621

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IvanLi-CN
Copy link

gltf-pipeline -i model.glb -o outputs/model.gltf -t
gltf-pipeline -o model-16.glb -i outputs/model.gltf -b

image

Fixed the problem that when the file name of a model mapping has a "#" symbol, the content after it is parsed as URL Hash, resulting in a missing file address.

@IvanLi-CN IvanLi-CN force-pushed the fix-can-not-parse-filename-with-hash-sign branch from 4578a9d to 38267f0 Compare August 30, 2022 01:44
@leonchen
Copy link

I think the fix should replace all the # characters so it would either use replaceAll or regexp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants