Fix(cli): import-runtime #3702
Merged
Fix(cli): import-runtime #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto development
…nto development
…nto development
dimartiro
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya and
axaysagathiya
as code owners
q9f
approved these changes
Jan 17, 2024
EclesioMeloJunior
approved these changes
Jan 17, 2024
q9f
added
C-simple
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #3702 +/- ##
===============================================
+ Coverage 50.55% 50.57% +0.01%
===============================================
Files 229 229
Lines 28601 28605 +4
===============================================
+ Hits 14460 14466 +6
+ Misses 12620 12618 -2
Partials 1521 1521 |
dimartiro
added
S-cli
|
🎉 This PR is included in version 0.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
timwu20
pushed a commit
that referenced
this pull request
Apr 18, 2024
timwu20
pushed a commit
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I started this PR to solve an issue we have while creating a spec using a custom runtime
Tests
One way to test it is trying to create a new spec file using a custom runtime, it failed with a nil pointer before this fix
gossamer import-runtime --chain chain/westend/chain-spec-raw.json --wasm-file westend_runtime.compact.compressed.wasm > chain/westend-dev/westend-dev-spec.jsonIssues
Close #3701
Also related with #3679 and #3692