Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scripts): remove deprecated trie-state script #4270

Merged
merged 6 commits into from
Oct 22, 2024
Merged

feat(scripts): remove deprecated trie-state script #4270

merged 6 commits into from
Oct 22, 2024

Conversation

EclesioMeloJunior
Copy link
Member

Changes

  • Removes old and unused script as well as the RPC endpoint that was made for it.

Tests

N/A

Issues

dimartiro
dimartiro approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@dimartiro dimartiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but it seems you need to update the Unsafe_method_state_trie_should_not_be_reachable test too

@EclesioMeloJunior EclesioMeloJunior merged commit 722e7ae into development Oct 22, 2024
24 checks passed
@EclesioMeloJunior EclesioMeloJunior deleted the eclesio/remove-old-script branch October 22, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haikoschol haikoschol haikoschol approved these changes

@dimartiro dimartiro dimartiro approved these changes

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya kishansagathiya is a code owner

@P1sar P1sar Awaiting requested review from P1sar P1sar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove old trie-state script folder
3 participants
@EclesioMeloJunior @haikoschol @dimartiro