-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parser): support nameless tf resources #6510
fix(parser): support nameless tf resources #6510
Conversation
4be00c5
to
0cb7fd8
Compare
@cxMiguelSilva any chance you look on this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @liorj-orca, sorry for the late response,
The proposed changes to the Terraform parser LGTM. Would you just be able to add a unit test to ensure that this issue will be validated from other changes from now onward?
0cb7fd8
to
3b27ae1
Compare
3b27ae1
to
49568bf
Compare
54a3054
to
374124d
Compare
374124d
to
512eff3
Compare
Hi @cxMiguelSilva, i added a simple test for that, can we push it forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @liorj-orca, I have made the initial code review, and now it will be submitted to QA analysis. Once we have the ok we will merge it. Thank you so much for this contribution to this missing case on the Terraform parser 😀 |
this PR solves the fatal error we are getting when scanning a TF resources without a name. for exmple for the following, we were getting the following fatal error:
the error we are getting:
overall, tf resources withtout a name are not valid, but I belive it would be better inspecting those resources anyway and be able to indicate other issues we have on them other than completly fail the scan
Proposed Changes
I submit this contribution under the Apache-2.0 license.