Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): alicloud rds instance address publicly accessible terraform query refactor #6559

Merged
merged 8 commits into from
Aug 11, 2023
Merged

fix(query): alicloud rds instance address publicly accessible terraform query refactor #6559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6202933
fix(query): Alicloud RDS Instance Address Publicly Accessible
cx-henriqueAlvelos Jul 31, 2023
084c119
changed queryname
cx-henriqueAlvelos Aug 3, 2023
840f37a
Fixed positive expected results
cx-henriqueAlvelos Aug 3, 2023
1f5fe63
Merge branch 'master' into kics-782-alicloud-terraform
cx-henriqueAlvelos Aug 4, 2023
8fc2645
Fix queryname
cx-henriqueAlvelos Aug 9, 2023
c6f80c9
Merge branch 'kics-782-alicloud-terraform' of https://github.com/Chec…
cx-henriqueAlvelos Aug 9, 2023
77ff350
fixed search_key
cx-henriqueAlvelos Aug 10, 2023
91cb4ed
Merge branch 'master' into kics-782-alicloud-terraform
asofsilva Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...nstance_publicly_accessible/metadata.json → ...address_publicly_accessible/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "faaefc15-51a5-419e-bb5e-51a4b5ab3485",
"queryName": "DB Instance Publicly Accessible",
"queryName": "RDS DB Instance Publicly Accessible",
"severity": "HIGH",
"category": "Insecure Configurations",
"descriptionText": "The field 'address' should not be set to '0.0.0.0/0'",
Expand Down
0 ...b_instance_publicly_accessible/query.rego → ...ce_address_publicly_accessible/query.rego
View file
Open in desktop
File renamed without changes.
0 ...nce_publicly_accessible/test/negative1.tf → ...ess_publicly_accessible/test/negative1.tf
View file
Open in desktop
File renamed without changes.
0 ...nce_publicly_accessible/test/negative2.tf → ...ess_publicly_accessible/test/negative2.tf
View file
Open in desktop
File renamed without changes.
0 ...nce_publicly_accessible/test/positive1.tf → ...ess_publicly_accessible/test/positive1.tf
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...ssible/test/positive_expected_result.json → ...ssible/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[
{
"queryName": "DB Instance Publicly Accessible",
"queryName": "RDS DB Instance Publicly Accessible",
"severity": "HIGH",
"line": 10,
"fileName": "positive1.tf"
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/alicloud/rds_instance_publicly_accessible/query.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ CxPolicy[result] {
"documentId": input.document[i].id,
"resourceType": "alicloud_db_instance",
"resourceName": tf_lib.get_resource_name(resource, name),
"searchKey": sprintf("alicloud_db_instance[%s].security_ips.%s", [name,x]),
"searchKey": sprintf("alicloud_db_instance[%s].security_ips[%v]", [name,x]),
"issueType": "IncorrectValue",
"keyExpectedValue": sprintf("'%s' should not be in 'security_ips' list", [sec_ip]),
"keyActualValue": sprintf("'%s' is in 'security_ips' list", [sec_ip]),
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/alicloud/rds_instance_ssl_action_disabled/query.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ CxPolicy[result] {
"documentId": input.document[i].id,
"resourceType": "alicloud_db_instance",
"resourceName": tf_lib.get_resource_name(resource, name),
"searchKey": sprintf("alicloud_db_instance[%s]]", [name]),
"searchKey": sprintf("alicloud_db_instance[%s]", [name]),
"issueType": "MissingAttribute",
"keyExpectedValue": "'ssl_action' value should be 'Open'",
"keyActualValue": "'ssl_action' is not defined",
Expand Down
Loading