Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): fixed terraform azure query where min_tls_version was not accepting string #6622

Merged
merged 8 commits into from
Aug 17, 2023
Merged

fix(query): fixed terraform azure query where min_tls_version was not accepting string #6622

merged 8 commits into from
Aug 17, 2023

Conversation

freitasmillena
Copy link
Contributor

Closes #6618

Proposed Changes

  • Convert min_tls_version to number before comparing with latest tls version.
  • Added positive and negative tests.

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added query New query feature terraform Terraform query azure PR related with Azure Cloud labels Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023 •
edited
Loading

kics-logo

KICS version: v1.7.4

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 2

@github-actions github-actions bot removed query New query feature terraform Terraform query azure PR related with Azure Cloud labels Aug 17, 2023
@asofsilva asofsilva merged commit 685fd53 into master Aug 17, 2023
16 checks passed
@asofsilva asofsilva deleted the fix6618 branch August 17, 2023 11:10
@p-linnane p-linnane mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-cx gabriel-cx gabriel-cx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update function_app_not_using_latest_tls_encryption_version for Azure (Terraform)
3 participants
@freitasmillena @gabriel-cx @asofsilva