Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): ansible config allow unsafe lookups #6626

Merged
merged 10 commits into from
Sep 13, 2023
Merged

feat(query): ansible config allow unsafe lookups #6626

merged 10 commits into from
Sep 13, 2023

Conversation

cx-henriqueAlvelos
Copy link
Contributor

@cx-henriqueAlvelos cx-henriqueAlvelos commented Aug 9, 2023 •
edited
Loading

Proposed Changes

  • Query
  • Tests
  • Positive Expected Results

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added feature New feature query New query feature ansible Ansible query labels Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023 •
edited
Loading

kics-logo

KICS version: v1.7.6

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

@cx-henriqueAlvelos cx-henriqueAlvelos self-assigned this Aug 9, 2023
cxMiguelSilva
cxMiguelSilva previously requested changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add searchLine

assets/queries/ansible/config/allow_unsafe_lookups_enabled/query.rego Show resolved Hide resolved
@cx-henriqueAlvelos cx-henriqueAlvelos dismissed cxMiguelSilva’s stale review September 9, 2023 07:52

There is no need to add searchLine since it can vary with different files

cxMiguelSilva
cxMiguelSilva previously approved these changes Sep 11, 2023
View reviewed changes
@asofsilva asofsilva merged commit b4aa92e into master Sep 13, 2023
18 checks passed
@asofsilva asofsilva deleted the kics-968-allow-unsafe-lookups branch September 13, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

@gabriel-cx gabriel-cx Awaiting requested review from gabriel-cx

@pereiramarco011 pereiramarco011 Awaiting requested review from pereiramarco011

Assignees

@cx-henriqueAlvelos cx-henriqueAlvelos

Labels
ansible Ansible query feature New feature query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cx-henriqueAlvelos @cxMiguelSilva @asofsilva