Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): severity check tests #6975

Merged
merged 5 commits into from
Apr 2, 2024
Merged

fix(tests): severity check tests #6975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd72550
fix query severity in tests
pereiramarco011 Mar 28, 2024
9413e0c
fix inspector
pereiramarco011 Mar 28, 2024
4d11a45
Merge branch 'kics-748-update-query-metadata' into kics-748-fix-sever…
pereiramarco011 Mar 28, 2024
6d08ab8
Merge branch 'master' into kics-748-fix-severitycheck-tests
gabriel-cx Mar 28, 2024
c4b018f
Merge branch 'master' into kics-748-fix-severitycheck-tests
cxMiguelSilva Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 3 additions & 3 deletions assets/queries/ansible/aws/alb_listening_on_http/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[
{
"queryName": "ALB Listening on HTTP",
"severity": "HIGH",
"severity": "MEDIUM",
"line": 11
},
{
"queryName": "ALB Listening on HTTP",
"severity": "HIGH",
"severity": "MEDIUM",
"line": 29
}
]
]
22 changes: 11 additions & 11 deletions assets/queries/ansible/aws/ami_not_encrypted/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[
{
"queryName": "AMI Not Encrypted",
"severity": "HIGH",
"line": 6
},
{
"queryName": "AMI Not Encrypted",
"severity": "HIGH",
"line": 13
}
]
{
"queryName": "AMI Not Encrypted",
"severity": "MEDIUM",
"line": 6
},
{
"queryName": "AMI Not Encrypted",
"severity": "MEDIUM",
"line": 13
}
]
22 changes: 11 additions & 11 deletions assets/queries/ansible/aws/api_gateway_xray_disabled/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[
{
"queryName": "API Gateway X-Ray Disabled",
"severity": "MEDIUM",
"line": 8
},
{
"queryName": "API Gateway X-Ray Disabled",
"severity": "MEDIUM",
"line": 12
}
]
{
"queryName": "API Gateway X-Ray Disabled",
"severity": "LOW",
"line": 8
},
{
"queryName": "API Gateway X-Ray Disabled",
"severity": "LOW",
"line": 12
}
]
8 changes: 4 additions & 4 deletions assets/queries/ansible/aws/authentication_without_mfa/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
[
{
"queryName": "Authentication Without MFA",
"severity": "HIGH",
"severity": "LOW",
"line": 2
},
{
"queryName": "Authentication Without MFA",
"severity": "HIGH",
"severity": "LOW",
"line": 9
},
{
"queryName": "Authentication Without MFA",
"severity": "HIGH",
"severity": "LOW",
"line": 9
}
]
]
6 changes: 3 additions & 3 deletions ...le/aws/aws_password_policy_with_unchangeable_passwords/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[
{
"queryName": "AWS Password Policy With Unchangeable Passwords",
"severity": "MEDIUM",
"severity": "LOW",
"line": 9
},
{
"queryName": "AWS Password Policy With Unchangeable Passwords",
"severity": "MEDIUM",
"severity": "LOW",
"line": 21
}
]
]
6 changes: 3 additions & 3 deletions ...ries/ansible/aws/ca_certificate_identifier_is_outdated/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[
{
"queryName": "CA Certificate Identifier Is Outdated",
"severity": "HIGH",
"severity": "MEDIUM",
"line": 10
},
{
"queryName": "CA Certificate Identifier Is Outdated",
"severity": "HIGH",
"severity": "MEDIUM",
"line": 12
}
]
]
8 changes: 4 additions & 4 deletions ...nsible/aws/cloudfront_without_minimum_protocol_tls_1.2/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
[
{
"queryName": "CloudFront Without Minimum Protocol TLS 1.2",
"severity": "HIGH",
"severity": "MEDIUM",
"line": 18
},
{
"queryName": "CloudFront Without Minimum Protocol TLS 1.2",
"severity": "HIGH",
"severity": "MEDIUM",
"line": 37
},
{
"line": 40,
"queryName": "CloudFront Without Minimum Protocol TLS 1.2",
"severity": "HIGH"
"severity": "MEDIUM"
}
]
]
12 changes: 6 additions & 6 deletions assets/queries/ansible/aws/cloudfront_without_waf/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[
{
"queryName": "CloudFront Without WAF",
"severity": "LOW",
"line": 2
}
]
{
"queryName": "CloudFront Without WAF",
"severity": "MEDIUM",
"line": 2
}
]
12 changes: 6 additions & 6 deletions assets/queries/ansible/aws/cloudtrail_logging_disabled/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[
{
"queryName": "CloudTrail Logging Disabled",
"severity": "HIGH",
"line": 5
}
]
{
"queryName": "CloudTrail Logging Disabled",
"severity": "MEDIUM",
"line": 5
}
]
12 changes: 6 additions & 6 deletions ...s/queries/ansible/aws/cloudtrail_multi_region_disabled/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[
{
"queryName": "CloudTrail Multi Region Disabled",
"severity": "MEDIUM",
"line": 7
}
]
{
"queryName": "CloudTrail Multi Region Disabled",
"severity": "LOW",
"line": 7
}
]
10 changes: 5 additions & 5 deletions .../ansible/aws/cloudtrail_not_integrated_with_cloudwatch/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
[
{
"severity": "MEDIUM",
"severity": "LOW",
"line": 2,
"queryName": "CloudTrail Not Integrated With CloudWatch"
},
{
"severity": "MEDIUM",
"severity": "LOW",
"line": 2,
"queryName": "CloudTrail Not Integrated With CloudWatch"
},
{
"queryName": "CloudTrail Not Integrated With CloudWatch",
"severity": "MEDIUM",
"severity": "LOW",
"line": 14
},
{
"queryName": "CloudTrail Not Integrated With CloudWatch",
"severity": "MEDIUM",
"severity": "LOW",
"line": 27
}
]
]
22 changes: 11 additions & 11 deletions ...ueries/ansible/aws/cloudtrail_sns_topic_name_undefined/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[
{
"queryName": "CloudTrail SNS Topic Name Undefined",
"severity": "MEDIUM",
"line": 2
},
{
"queryName": "CloudTrail SNS Topic Name Undefined",
"severity": "MEDIUM",
"line": 15
}
]
{
"queryName": "CloudTrail SNS Topic Name Undefined",
"severity": "INFO",
"line": 2
},
{
"queryName": "CloudTrail SNS Topic Name Undefined",
"severity": "INFO",
"line": 15
}
]
6 changes: 3 additions & 3 deletions ...ible/aws/cloudwatch_without_retention_period_specified/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[
{
"queryName": "CloudWatch Without Retention Period Specified",
"severity": "MEDIUM",
"severity": "INFO",
"line": 2
},
{
"queryName": "CloudWatch Without Retention Period Specified",
"severity": "MEDIUM",
"severity": "INFO",
"line": 7
}
]
]
6 changes: 3 additions & 3 deletions assets/queries/ansible/aws/cmk_rotation_disabled/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
[
{
"queryName": "CMK Rotation Disabled",
"severity": "HIGH",
"severity": "LOW",
"line": 2,
"fileName": "positive1.yaml"
},
{
"queryName": "CMK Rotation Disabled",
"severity": "HIGH",
"severity": "LOW",
"line": 7,
"fileName": "positive2.yaml"
}
]
]
6 changes: 3 additions & 3 deletions ...onfig_configuration_aggregator_to_all_regions_disabled/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[
{
"queryName": "Configuration Aggregator to All Regions Disabled",
"severity": "MEDIUM",
"severity": "LOW",
"line": 10
},
{
"queryName": "Configuration Aggregator to All Regions Disabled",
"severity": "MEDIUM",
"severity": "LOW",
"line": 24
}
]
]
4 changes: 2 additions & 2 deletions ...ible/aws/config_rule_for_encrypted_volumes_is_disabled/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[
{
"queryName": "Config Rule For Encrypted Volumes Disabled",
"severity": "MEDIUM",
"severity": "HIGH",
"line": 2
}
]
]
38 changes: 19 additions & 19 deletions ...ount_iam_assume_role_policy_without_external_id_or_mfa/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
[
{
"queryName": "Cross-Account IAM Assume Role Policy Without ExternalId or MFA",
"severity": "MEDIUM",
"line": 4,
"fileName": "positive1.yaml"
},
{
"queryName": "Cross-Account IAM Assume Role Policy Without ExternalId or MFA",
"severity": "MEDIUM",
"line": 4,
"fileName": "positive2.yaml"
},
{
"queryName": "Cross-Account IAM Assume Role Policy Without ExternalId or MFA",
"severity": "MEDIUM",
"line": 4,
"fileName": "positive3.yaml"
}
]
{
"queryName": "Cross-Account IAM Assume Role Policy Without ExternalId or MFA",
"severity": "HIGH",
"line": 4,
"fileName": "positive1.yaml"
},
{
"queryName": "Cross-Account IAM Assume Role Policy Without ExternalId or MFA",
"severity": "HIGH",
"line": 4,
"fileName": "positive2.yaml"
},
{
"queryName": "Cross-Account IAM Assume Role Policy Without ExternalId or MFA",
"severity": "HIGH",
"line": 4,
"fileName": "positive3.yaml"
}
]
6 changes: 3 additions & 3 deletions ...ueries/ansible/aws/db_security_group_with_public_scope/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[
{
"queryName": "DB Security Group With Public Scope",
"severity": "HIGH",
"severity": "CRITICAL",
"line": 22
},
{
"queryName": "DB Security Group With Public Scope",
"severity": "HIGH",
"severity": "CRITICAL",
"line": 53
}
]
]
10 changes: 5 additions & 5 deletions assets/queries/ansible/aws/ebs_volume_encryption_disabled/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
[
{
"queryName": "EBS Volume Encryption Disabled",
"severity": "MEDIUM",
"severity": "HIGH",
"line": 5
},
{
"queryName": "EBS Volume Encryption Disabled",
"severity": "MEDIUM",
"severity": "HIGH",
"line": 12
},
{
"queryName": "EBS Volume Encryption Disabled",
"severity": "MEDIUM",
"severity": "HIGH",
"line": 19
},
{
"queryName": "EBS Volume Encryption Disabled",
"severity": "MEDIUM",
"severity": "HIGH",
"line": 24
}
]
]
Loading
Loading