Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(go): update go version to 1.23.1 #7251

Merged
merged 37 commits into from
Sep 13, 2024
Merged

update(go): update go version to 1.23.1 #7251

merged 37 commits into from
Sep 13, 2024

Conversation

ArturRibeiro-CX
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX commented Sep 9, 2024 •
edited
Loading

Reason for Proposed Changes

  • go version 1.22.5 has 3 known vulnerabilities;

Proposed Changes

  • update go version from 1.22.5 to version 1.23.1;
  • revert gosec version to v2.20.0;
  • update dockerfile images and add git to dockerfile;
  • tackle new golang-lint issues;
  • for the linting job, ubuntu-20.04 is the most stable version used for runner;

I submit this contribution under the Apache-2.0 license.

@ArturRibeiro-CX ArturRibeiro-CX requested a review from a team as a code owner September 9, 2024 16:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024 •
edited
Loading

kics-logo

KICS version: v2.1.1

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

JulioSCX
JulioSCX previously approved these changes Sep 11, 2024
View reviewed changes
@ArturRibeiro-CX ArturRibeiro-CX changed the title update(go): update go version to 1.22.7 update(go): update go version to 1.23.1 Sep 11, 2024
cx-ruiaraujo
cx-ruiaraujo previously approved these changes Sep 11, 2024
View reviewed changes
cxMiguelSilva
cxMiguelSilva previously approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@cxMiguelSilva cxMiguelSilva merged commit a0960c1 into master Sep 13, 2024
26 checks passed
@cxMiguelSilva cxMiguelSilva deleted the update_go_version branch September 13, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

@cx-ruiaraujo cx-ruiaraujo cx-ruiaraujo left review comments

@JulioSCX JulioSCX JulioSCX left review comments

Assignees
No one assigned
Labels
dockerfile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArturRibeiro-CX @cxMiguelSilva @cx-ruiaraujo @JulioSCX