Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gcp): rename test files resources to fix parsing errors on gcp queries #7253

Merged
merged 6 commits into from
Sep 27, 2024
Merged

fix(gcp): rename test files resources to fix parsing errors on gcp queries #7253

merged 6 commits into from
Sep 27, 2024

Conversation

ArturRibeiro-CX
Copy link
Contributor

Reason for Proposed Changes

  • parsing error was thrown when parsing gcp queries;

Proposed Changes

  • rename resources from gcp queries negative tests in order to fix parsing error;

I submit this contribution under the Apache-2.0 license.

@ArturRibeiro-CX ArturRibeiro-CX requested a review from a team as a code owner September 11, 2024 08:19
@github-actions github-actions bot added bug Something isn't working query New query feature gcp PR related with GCP Cloud labels Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

kics-logo

KICS version: v2.1.1

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

@ArturRibeiro-CX ArturRibeiro-CX changed the title bug(gcp): rename test files resources to fix parsing errors on gcp queries fix(gcp): rename test files resources to fix parsing errors on gcp queries Sep 11, 2024
@github-actions github-actions bot removed the bug Something isn't working label Sep 11, 2024
EduardoSemanas
EduardoSemanas approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@EduardoSemanas EduardoSemanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArturRibeiro-CX ArturRibeiro-CX merged commit 90c0e8a into master Sep 27, 2024
27 checks passed
@ArturRibeiro-CX ArturRibeiro-CX deleted the fix_parsing_negative_test_gcp_queries branch September 27, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduardoSemanas EduardoSemanas EduardoSemanas approved these changes

Assignees
No one assigned
Labels
gcp PR related with GCP Cloud query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArturRibeiro-CX @EduardoSemanas