fix handling when tarinfo is None - #955
Open
dirkhub wants to merge 1 commit into
Open
Conversation
For unsupported file types like Unix sockets and possibly other types, TarFile.getattrinfo() can return None. This commit reverts the changes from 77898dc to handle avoid crashes.
Contributor
Author
|
@englertor hello, it seems the testing workflow on this new pull-reqeuest once again failed due to timeouts, not real errors in the pull request, Could you please verify the pull reqeust? Kind regards, Dirk (dirkhub / svalabs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For unsupported file types like Unix sockets and possibly other types, TarFile.getattrinfo() can return None. This commit reverts the changes from 77898dc to avoid crashes. (change I19d966fe510b994b0e5809cdc394d7e4e87a106d)
The problem happened at a customer so that "omd backup" failed with a traceback and no site backup was possible after a 2.5 update from 2.4. It could be fixed after we compared it to the 2.4 code and reverted the line to "if tarinfo is None or not predicate(tarinfo):", which is more robust in real life environments.
Kind regards, Dirk.