moved the theme changer slightly down #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes are really small but this is my first PR to this repo and flutter in general! |
|
@anuragrao04 Thanks for contributing, can you send a preview on Android with the above change ? |
|
Hey @anuragrao04, Instead of hardcoding, could you implement it with |
|
sure! I'll get it done as soon as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244
Changes made in this PR - The theme changer button has been moved slightly down inorder to avoid hitting the dynamic island on newer iPhone models
Screenshots of the changes -
Refer the original issue for the before picture. After picture: