Skip to content

Isolate telemetry test mock endpoints - #526

Open
sdairs wants to merge 1 commit into
issue-410-cloud-integration-decisionfrom
issue-525-telemetry-test-event-leak
Open

Isolate telemetry test mock endpoints#526
sdairs wants to merge 1 commit into
issue-410-cloud-integration-decisionfrom
issue-525-telemetry-test-event-leak

Conversation

@sdairs

@sdairs sdairs commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • give every telemetry test sandbox a unique ingest path instead of sharing /v1/telemetry
  • filter received requests by that test-owned path so a delayed child hitting a reused port cannot satisfy or fail another test
  • apply the same path isolation to the slow-endpoint case and add focused coverage for stale unmatched requests

Closes #525

Verification

  • cargo fmt --all -- --check
  • cargo test -p clickhousectl --test telemetry_test
  • telemetry test binary repeated 50 times (1,150 tests passed)
  • cargo test -p clickhousectl
  • cargo clippy -p clickhousectl --all-targets -- -D warnings

Stack

@sdairs
sdairs force-pushed the issue-525-telemetry-test-event-leak branch from b1df8e9 to ad9d00d Compare August 25, 2026 20:56
@sdairs sdairs mentioned this pull request Aug 25, 2026

@iskakaushik iskakaushik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdairs
sdairs force-pushed the issue-525-telemetry-test-event-leak branch from ad9d00d to 288f63f Compare August 26, 2026 09:28
@sdairs
sdairs force-pushed the issue-525-telemetry-test-event-leak branch from 288f63f to f8699b1 Compare August 26, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent first-run telemetry requests leaking between test mocks

2 participants