CP-46909: Batch Dependabot dependency updates - #982
Merged
Conversation
Dependabot opened a batch of dependency PRs against this repo. Every bump scoped to the root module fails the `format` and `generate` CI jobs, while the identical bump scoped to /tests passes. Root Cause: tests/go.mod carries `replace github.com/cloudzero/cloudzero-agent => ../`, so the tests module resolves the root module from the local path. The `format` target runs `go mod tidy` in /, /.tools and /tests, so bumping a dependency in the root module also rewrites tests/go.mod and tests/go.sum. Dependabot only commits files for the module it is updating, so CI diffs the tree afterwards and fails on the untidied files. Batching the bumps onto one branch and running the tidy once clears this for all of them, and avoids each merge invalidating the go.sum of every branch still open. Functional Requirements: 1. Root module dependencies must be current. Bumped k8s.io/api and k8s.io/apimachinery to v0.36.4, github.com/stretchr/testify to v1.12.1, github.com/parquet-go/parquet-go to v0.32.0, github.com/minio/minio-go/v7 to v7.3.0, github.com/launchdarkly/go-jsonstream/v3 to v3.1.2, google.golang.org/protobuf to the v1.36.12 release (off the pseudo-version), and github.com/shirou/gopsutil/v4 to v4.26.7. 2. Tests module dependencies must be current. Bumped k8s.io/api, k8s.io/apimachinery and k8s.io/client-go to v0.36.4, github.com/stretchr/testify to v1.12.1, and github.com/testcontainers/testcontainers-go to v0.44.0. 3. Tools module dependencies must be current. Bumped honnef.co/go/tools to v0.8.1 and helm.sh/helm/v3 to v3.21.4. helm v3.21.4 imports ProtonMail/go-crypto/openpgp from pkg/provenance, which needs new .tools/go.sum entries. 4. All three modules must be tidy so `format` and `generate` pass. Ran `make format generate`. No Go source needed reformatting and no generated artifact changed, so the only diff is the go.mod and go.sum churn above. Validation: - `make build` produces all 10 binaries. - `make test` passes: 65 packages, 0 failures. - `make generate` leaves the tree clean. - logrus, prometheus/prometheus and moby/go-archive are deliberately left at their current versions. Those bumps fail for reasons unrelated to module tidiness and are handled separately. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Picks up the Dependabot bumps for the two pinned actions in the workflows. Functional Requirements: 1. docker/setup-buildx-action must move from v4.2.0 to v4.3.0. Updated both pins in .github/workflows/docker-build.yml. The action is pinned by commit SHA with the version in a trailing comment, so the SHA and the comment are both updated. 2. renovatebot/github-action must move from v46.2.1 to v46.2.2. Updated the tag pin in .github/workflows/renovate.yml. Validation: - `make format` leaves both workflow files unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The certs stage in docker/Dockerfile pins gcr.io/distroless/static-debian12:debug by digest. Upstream republished the tag, so the pin moves to the current build. Functional Requirements: 1. The pinned digest must track the current upstream :debug image. Updated the sha256 digest on the certs stage in docker/Dockerfile from 869bb6d to e60a053. Validation: - The digest is only consumed by the container build, so `make build` is unaffected. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
amfelso
marked this pull request as ready for review
August 26, 2026 20:44
Greptile SummaryThis PR batches dependency updates across the runtime, test, and tooling Go modules, updates two GitHub Actions, and refreshes the distroless image digest.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code defect identified. The dependency manifests and checksums are updated together, workflow and image changes retain their existing execution models, and the investigated compatibility and security leads did not establish a reachable failure introduced by this PR. Important Files Changed
Reviews (1): Last reviewed commit: "CP-46909: Bump distroless base image dig..." | Re-trigger Greptile |
josephbarnett
approved these changes
Aug 27, 2026
josephbarnett
left a comment
Collaborator
There was a problem hiding this comment.
Fix the builds and I bet this will all work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batches 18 of the open Dependabot dependency PRs onto one branch.
Root-module bumps fail
formatandgenerate, becauseformattidies all three modules and a root bump also rewritestests/go.sum, which Dependabot doesn't commit. One tidy commit fixes all of them.c6c0ae14— Go module bumps across/,/testsand/.tools, thenmake format generateac762dfb—docker/setup-buildx-action→ v4.3.0,renovatebot/github-action→ v46.2.2962c8c65—distroless/static-debian12:debugdigest →e60a053Supersedes #952, #953, #958, #959, #960, #962, #964, #966, #968, #970, #971, #973, #974, #976, #977, #978, #979, #981.
Left for separate PRs: #972, #969, #967, #957, #954 fail for reasons unrelated to tidiness. #975 and #980 are the
/testshalves of #972 and #969, so they move with them.Validation
make build,make test(65 packages, 0 failures) andmake generateall clean locally.lintandanalyzedon't run on macOS here, so CI covers those.🤖 Generated with Claude Code