-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
database: change datetime into start and end time strings #53
Draft
abhiramtilakiiit
wants to merge
7
commits into
master
Choose a base branch
from
add_duration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhavberi
requested changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the timezone message/information in the Event Form (so that user knows in what timezone they should select the time)
bhavberi
reviewed
May 27, 2024
bhavberi
force-pushed
the
master
branch
2 times, most recently
from
May 27, 2024 19:20
5fbef6d
to
a219ac2
Compare
bhavberi
force-pushed
the
master
branch
5 times, most recently
from
June 15, 2024 13:18
860f48e
to
e1d6e79
Compare
bhavberi
force-pushed
the
master
branch
5 times, most recently
from
July 9, 2024 21:10
f6e1bae
to
4e77c41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The current way of storing DateTime elements in the database is causing database corruption.
Storing strings in the datetime period feels more safe and also prevents other timezone problems like #48
from happening.
Changes Proposed
Linked PRs