Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database: change datetime into start and end time strings #53

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

abhiramtilakiiit
Copy link
Contributor

@abhiramtilakiiit abhiramtilakiiit commented May 22, 2024

Overview

The current way of storing DateTime elements in the database is causing database corruption.
Storing strings in the datetime period feels more safe and also prevents other timezone problems like #48
from happening.

Changes Proposed

  1. Store times as string without any timezone data, assuming everything as IST.
  2. Store timings of event as two variables, rather than a tuple, to prevent any unwanted confusion in db
  3. Store duration of the event for security for now. It will not be used currently anywhere, except if needed to restore corruption in db in times of the events

Linked PRs

Copy link
Member

@bhavberi bhavberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the timezone message/information in the Event Form (so that user knows in what timezone they should select the time)

@bhavberi bhavberi force-pushed the master branch 2 times, most recently from 5fbef6d to a219ac2 Compare May 27, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants