Merge pull request #55 from Coaktion/fix/change-method-to-type-zendesk

feat: change method to type on Zendesk requests
Coaktion · Oct 23, 2023 · 326e19e · 326e19e
2 parents a43fccf + e4dbfc4
commit 326e19e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/src/zendesk.ts b/src/zendesk.ts
@@ -44,7 +44,7 @@ export class ZendeskClient
     try {
       return await this.client.request({
         url: payload.url,
-        method: payload.method,
+        type: payload.method,
         secure: this.isProduction,
         contentType: payload.contentType
           ? payload.contentType

diff --git a/tests/zendesk.test.ts b/tests/zendesk.test.ts
@@ -248,11 +248,13 @@ describe('ZendeskClientBase', () => {
     await zendeskClientBase.makeRequest(payload);
     delete payload.retryCount;
     expect(mockZendeskClient.request).toHaveBeenCalledWith({
-      ...payload,
+      url: payload.url,
+      type: payload.method,
       secure: false,
       timeout: 5000,
       contentType: 'application/x-www-form-urlencoded',
-      httpCompleteResponse: true
+      httpCompleteResponse: true,
+      headers: {}
     });
   });
 
@@ -338,11 +340,13 @@ describe('ZendeskClientBase', () => {
     await zendeskClientBase.makeRequest(payload);
     delete payload.retryCount;
     expect(mockZendeskClient.request).toHaveBeenCalledWith({
-      ...payload,
+      url: payload.url,
+      type: payload.method,
       secure: false,
       timeout: 5000,
       contentType: expectedContentType,
-      httpCompleteResponse: true
+      httpCompleteResponse: true,
+      headers: {}
     });
     expect(mockZendeskClient.request).toHaveBeenCalledTimes(1);
   });
@@ -357,12 +361,14 @@ describe('ZendeskClientBase', () => {
     await zendeskClientBase.makeRequest(payload);
     delete payload.retryCount;
     expect(mockZendeskClient.request).toHaveBeenCalledWith({
-      ...payload,
+      url: payload.url,
+      type: payload.method,
       secure: false,
       data: expectedData,
       httpCompleteResponse: true,
       timeout: 5000,
-      contentType: 'application/x-www-form-urlencoded'
+      contentType: 'application/x-www-form-urlencoded',
+      headers: {}
     });
     expect(mockZendeskClient.request).toHaveBeenCalledTimes(1);
   });
@@ -405,7 +411,8 @@ describe('ZendeskClientBase', () => {
     delete payload.retryCount;
 
     expect(mockZendeskClient.request).toHaveBeenCalledWith({
-      ...payload,
+      url: payload.url,
+      type: payload.method,
       secure: false,
       headers: expectedHeader,
       httpCompleteResponse: true,