Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/add data and content type zendesk #40

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

JoaoMacedo03
Copy link
Contributor

Resolves #39

Description:
In the makeRequest method, the contentType is hardcoded to 'application/x-www-form-urlencoded'. Additionally, the 'data' parameter isn't being set, even when provided as an argument.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Why is this change required?:
To have the flexibility to specify various contentTypes and utilize HTTP methods beyond just GET with ZAF.request.


Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JoaoMacedo03 JoaoMacedo03 merged commit 2ffcf06 into main Aug 15, 2023
5 checks passed
@JoaoMacedo03 JoaoMacedo03 deleted the fix/add-data-and-content-type-zendesk branch August 15, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Zendesk Client MakeRequest does not accept custom ContentType and it's not receiving body
3 participants