chore: small fixes for simulation subprocess tracking - #513
Conversation
ArgAction::Set made the value mandatory, so the bare flag failed with "a value is required". Presence-only matches the false default.
Per-thread dumps are now enabled with --simulation-track-subprocess instead of --cycle-estimation, so thread separation follows the option that changes what is measured rather than how cycles are estimated.
Greptile SummaryThis PR makes subprocess tracking a presence-only CLI flag and ties both Valgrind instrumentation startup and thread separation to that setting.
Confidence Score: 5/5The PR appears safe to merge based on the accepted review findings, with the explicitly acknowledged experimental Tracegrind limitation remaining a deliberate follow-up decision. No unacknowledged, concretely reachable failure was established in the changed CLI parsing or Callgrind output behavior.
|
| Filename | Overview |
|---|---|
| src/cli/shared.rs | Simplifies subprocess-tracking argument parsing to support the bare boolean flag; no actionable current compatibility failure was established. |
| src/executor/valgrind/measure.rs | Rebinds thread separation to subprocess tracking; the known Tracegrind incompatibility is explicitly acknowledged in the PR description. |
Reviews (1): Last reviewed commit: "refactor(valgrind): tie --separate-threa..." | Re-trigger Greptile
Merging this PR will not alter performance
|
No description provided.