mctpd: handle Discovery Notify (DSP0236 command 0x0D) - #176
Closed
FXN-Bruce wants to merge 2 commits into
Closed
Conversation
FXN-Bruce
changed the title
FXN-Bruce
force-pushed
the
discovery-notify
branch
from
August 28, 2026 08:21
e4540d7 to
f6aab5c
Compare
mctpd currently falls through to handle_control_unsupported() for an incoming Discovery Notify, replying with an unsupported-command error and taking no other action. Add a handler that acknowledges the message (using physical addressing, since the sender may not have a valid EID yet) and emits a "DiscoveryNotify" D-Bus signal on the sender's interface object (au.com.codeconstruct.MCTP.BusOwner1 at /au/com/codeconstruct/mctp1/interfaces/<ifname>). The handler does not otherwise inspect or modify peer/EID state itself - reconciling what a Discovery Notify implies for a given peer is bus-owner policy, left to whatever subscribes to the signal. Assisted-by: Claude:claude-sonnet-5 Signed-off-by: Bruce Hung <bruce.jy.hung@fii-foxconn.com>
Cover the new Discovery Notify handler: mctpd should ack the command and emit a DiscoveryNotify signal on the sending interface's BusOwner1 object, both before and after the sender has an assigned EID. Assisted-by: Claude:claude-sonnet-5 Signed-off-by: Bruce Hung <bruce.jy.hung@fii-foxconn.com>
FXN-Bruce
force-pushed
the
discovery-notify
branch
from
August 28, 2026 08:24
f6aab5c to
99a9028
Compare
Member
|
Please sync with #165. |
Author
I see. Thank you. Withdrawing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mctpd currently falls through to handle_control_unsupported() for an
incoming Discovery Notify, replying with an unsupported-command error
and taking no other action.
Add a handler that acknowledges the message (using physical
addressing, since the sender may not have a valid EID yet) and emits
a "DiscoveryNotify" D-Bus signal on the sender's interface object
(au.com.codeconstruct.MCTP.BusOwner1 at
/au/com/codeconstruct/mctp1/interfaces/). The handler does not
otherwise inspect or modify peer/EID state itself - reconciling what
a Discovery Notify implies for a given peer is bus-owner policy, left
to whatever subscribes to the signal.