forked from googlesamples/google-signin-unity
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent migration attempt #3
Open
Thaina
wants to merge
27
commits into
CodeMasterYi:master
Choose a base branch
from
Thaina:newmigration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,672
−9,333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> convert to direct unity call to java add signin in editor and desktop support
Fix signOut and disconnect
seems it was needed...
Fixes & Improvements
Migrate ios to 7.1.0
update readme
Thaina
force-pushed
the
newmigration
branch
2 times, most recently
from
June 13, 2024 12:45
3da1816
to
6c3c741
Compare
@Thaina Hello, Thanks for your effort for this repository. But I dont want to pay much time on this. You can keep your change on your fork and let others download your optimized versions. Thank you very much! |
GoogleSignInImpl.GoogleSignIn_GetUserId #18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is deprecation and migration recommendation from signin system
: copied from readme >
https://developer.android.com/identity/sign-in/legacy-gsi-migration
https://developers.google.com/identity/sign-in/ios/quick-migration-guide
Thank for ios fix which was cherrypicked from this fork : https://github.com/pillsgood/google-signin-unity
Android was migrated to use
CredentialManager
andAuthorizationClient
since GoogleSignInAccount was deprecatedHowever,
GoogleIdTokenCredential
actually not provide numeric unique ID anymore and set email as userId instead, so I have to extract jwtsub
value from idToken (which seem like the same id as userId from GoogleSignIn of other platform)Tested in unity 2021.3.21 and unity 6000.0.4
Add UPM dependency with branch tag
https://github.com/Thaina/google-signin-unity.git#newmigration