Birmingham | may-2026-itp | Alexandra Clincu | Sprint 2 | Wireframe to Web Code - #1323
Closed
AlexandraClincu28 wants to merge 9 commits into
Closed
Birmingham | may-2026-itp | Alexandra Clincu | Sprint 2 | Wireframe to Web Code#1323AlexandraClincu28 wants to merge 9 commits into
AlexandraClincu28 wants to merge 9 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AlexandraClincu28
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
May 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this task, there are a few changes you need to make
LonMcGregor
added
Reviewed
added images
added fixed footer
added the attributes
replace image
AlexandraClincu28
added
the
Needs Review
LonMcGregor
removed
the
Needs Review
Fix footer positioning
AlexandraClincu28
added
the
Needs Review
|
Very close to being complete now! When I look on my screen, the footer is a bit too tall so it obscures part of the "read more" links in the bottom articles. Do you see that also on your device? |
LonMcGregor
removed
the
Needs Review
update footer
AlexandraClincu28
added
the
Needs Review
|
This is what I am seeing right now: Do you also see the same thing? |
LonMcGregor
removed
the
Needs Review
Add padding to main
AlexandraClincu28
added
the
Needs Review
Author
|
Thanks for the screenshot, that helped me understand the issue. I've made some adjustments to create more space below the content so the fixed footer shouldn't overlap the "Read more" links anymore. Thanks again for taking the time to review it. |
|
Perfect! this task is now completed |
LonMcGregor
removed
Needs Review
LonMcGregor
added
the
Complete
Member
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Created a Webpage based on the provided wireframe, styled the page using CSS and matched the layout to the wireframe design.