Skip to content

Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 2 | coursework - #1439

Closed
meneogbemi42-bit wants to merge 19 commits into
CodeYourFuture:mainfrom
meneogbemi42-bit:coursework/sprint2
Closed

Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 2 | coursework #1439
meneogbemi42-bit wants to merge 19 commits into
CodeYourFuture:mainfrom
meneogbemi42-bit:coursework/sprint2

Conversation

@meneogbemi42-bit

@meneogbemi42-bit meneogbemi42-bit commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
  • [ x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ x ] My changes meet the requirements of the task
  • [ x ] I have tested my changes
  • [ x ] My changes follow the style guide

This PR contains debugging, implementation, and interpretation work across multiple coding exercises focusing on function parameters, return values, and string manipulation in JavaScript.

@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@meneogbemi42-bit meneogbemi42-bit added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@meneogbemi42-bit meneogbemi42-bit changed the title Birmingham Coursework/sprint2 Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 2 | Coursework/sprint2 Jul 2, 2026
@meneogbemi42-bit meneogbemi42-bit added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@meneogbemi42-bit meneogbemi42-bit added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 2, 2026
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@meneogbemi42-bit meneogbemi42-bit added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 2, 2026
Liam310
Liam310 reviewed Jul 6, 2026
View reviewed changes
Comment thread Sprint-2/3-mandatory-implement/3-to-pounds.js
Liam310
Liam310 reviewed Jul 6, 2026
View reviewed changes
Comment thread Sprint-2/5-stretch-extend/format-time.js Outdated
@Liam310

Liam310 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Really nice explanations Ogbemi! Just a few comments but good work overall.

@Liam310 Liam310 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 7, 2026
@meneogbemi42-bit meneogbemi42-bit added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 7, 2026
@Liam310 Liam310 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 10, 2026
@meneogbemi42-bit meneogbemi42-bit added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 10, 2026
@Liam310 Liam310 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 10, 2026
@meneogbemi42-bit
Fix return statement placement in sum function
3d69494 
Moved the return statement to after the addition operation to ensure the function returns the correct result.
@meneogbemi42-bit meneogbemi42-bit added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 10, 2026
@Liam310 Liam310 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 14, 2026
@meneogbemi42-bit
Handle empty string case in capitalise function
de14732 
Updated the capitalise function to handle empty strings.
@meneogbemi42-bit meneogbemi42-bit added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 14, 2026
@Liam310

Liam310 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Nice one! I'm happy with this being done now 😄

@Liam310 Liam310 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 20, 2026
@meneogbemi42-bit meneogbemi42-bit mentioned this pull request Jul 20, 2026
Open
@illicitonion

illicitonion commented Aug 24, 2026

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Liam310 Liam310 Liam310 left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 🏕 Priority Mandatory This work is expected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meneogbemi42-bit @Liam310 @illicitonion