London | 26-ITP-May | Khaliun Baatarkhuu | Sprint 3 | Implement and Rewrite Tests - #1440
Closed
khaliun-dev wants to merge 10 commits into
Closed
London | 26-ITP-May | Khaliun Baatarkhuu | Sprint 3 | Implement and Rewrite Tests #1440khaliun-dev wants to merge 10 commits into
khaliun-dev wants to merge 10 commits into
Conversation
Implemented the getAngleType function to classify angles and added tests for various angle types.
Added additional tests for angle types including acute, right, obtuse, straight, reflex, and invalid angles.
Implemented the isProperFraction function and added tests for various cases.
Implemented the getCardValue function to return the value of a card based on its rank and suit. Added assertions to test valid card values and handle errors for invalid cards.
Added additional test cases for invalid card values to ensure proper error handling.
Added comprehensive Jest tests for the isProperFraction function, covering special cases, positive and negative proper and improper fractions.
Updated test cases for getCardValue function to use Jest syntax, covering all card types including Aces, number cards, face cards, and invalid cards.
khaliun-dev
added
📅 Sprint 3
LonMcGregor
reviewed
Jul 8, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, but still some things to work on
| } | ||
| const suits = ["♠", "♥", "♦", "♣"]; | ||
|
|
||
| const values = { |
There was a problem hiding this comment.
This is an interesting approach, good idea
| const isProperFraction = require("../implement/2-is-proper-fraction"); | ||
|
|
||
| // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories. | ||
| // Special case: denominator is zero |
There was a problem hiding this comment.
Be careful here in your tests - have you tried running them with npm test? Can you see what is missing?
LonMcGregor
added
Reviewed
Updated the isProperFraction function to handle negative values correctly and added additional test cases for comprehensive coverage.
|
You have some new test cases which is good, but when I run |
khaliun-dev
added
the
Needs Review
Author
|
@LonMcGregor hiya, i think i have managed to do it properly, finally! Can you please have a quick looksy? |
|
Great, yes, the exports were missing. Task is complete now |
LonMcGregor
added
Complete
Member
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Questions
None.