Cape Town | 25-ITP-May | Asanda Dunn | Sprint 3 | Coursework/sprint 3 implement and rewrite - #1453
Closed
asandagwala wants to merge 6 commits into
Closed
Conversation
asandagwala
added
Needs Review
LonMcGregor
reviewed
Jul 8, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, but still some things to work on
| assertEquals(isProperFraction(1, 2), true); | ||
| assertEquals(isProperFraction(10,20), true); | ||
| assertEquals(isProperFraction(80, 10), false); | ||
| assertEquals(isProperFraction(8, 16), true); |
There was a problem hiding this comment.
Does your testing consider valid proper fractions that include negatives?
| !isNaN(numericValue) && | ||
| numericValue >= 2 && | ||
| numericValue <= 10 && | ||
| String(numericValue) === rank |
|
|
||
| // Case 4: Negative Numbers | ||
| test("should handle negative integers according to mathematical comparison rules", () => { | ||
| expect(isProperFraction(-5, -2)).toEqual(true); |
There was a problem hiding this comment.
Are you sure these tests are correct for valid proper fractions?
| assertEquals(getCardValue("Q♠"), 10); | ||
| assertEquals(getCardValue("K♣"), 10); | ||
|
|
||
| assertThrows("invalid"); |
There was a problem hiding this comment.
Did you try running this, does "assertThrows" work here?
LonMcGregor
added
Reviewed
Member
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Module: Structure and testing data Sprint 3 work