Skip to content

London | 26-ITP-May | Liridona Shehu | Sprint 3 | Implement and rewrite - #1474

Closed
shehu-dona wants to merge 32 commits into
CodeYourFuture:mainfrom
shehu-dona:coursework/sprint-3-implement-and-rewrite
Closed

London | 26-ITP-May | Liridona Shehu | Sprint 3 | Implement and rewrite#1474
shehu-dona wants to merge 32 commits into
CodeYourFuture:mainfrom
shehu-dona:coursework/sprint-3-implement-and-rewrite

Conversation

@shehu-dona

@shehu-dona shehu-dona commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • [ x] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ x ] My changes meet the requirements of the task
  • [ x ] I have tested my changes
  • [ x ] My changes follow the style guide

Changelist

A PR with exercises using Jest

@github-actions

This comment has been minimized.

Sign in to view
@shehu-dona shehu-dona added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jul 6, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 6, 2026
@shehu-dona shehu-dona added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 6, 2026
@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 9, 2026
@shehu-dona

shehu-dona commented Jul 11, 2026

Copy link
Copy Markdown
Author

Hello @Luro91, I read your comments and and updated the work.

@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 11, 2026
@Luro91 Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 12, 2026
@Luro91

Luro91 commented Jul 12, 2026

Copy link
Copy Markdown

Hello @Luro91, I read your comments and and updated the work.

I don't see some of the changes you mentioned. Maybe they were not pushed?

@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 14, 2026
@shehu-dona

shehu-dona commented Jul 14, 2026

Copy link
Copy Markdown
Author

Hello @Luro91,
I updated the code. Accidentally I changed the wrong files and got confused while trying to revert the changes. However I made the changes again and pushed them to Github.

@shehu-dona shehu-dona mentioned this pull request Jul 14, 2026
Open
Luro91
Luro91 reviewed Jul 15, 2026
View reviewed changes

@Luro91 Luro91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negative fractions still need correct handling.

My tip for verifying that your submission is pushed: Always check the files changes page of the PR and see if the changes and the commits show up in Github: https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/pull/1474/changes

Comment thread Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js Outdated
@Luro91 Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 15, 2026
@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 15, 2026
@shehu-dona

shehu-dona commented Jul 15, 2026

Copy link
Copy Markdown
Author

Hello @Luro91
I updated the code again.

Luro91
Luro91 reviewed Jul 16, 2026
View reviewed changes

@Luro91 Luro91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. The code is working correctly now .

@Luro91 Luro91 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 16, 2026
@shehu-dona

shehu-dona commented Jul 17, 2026

Copy link
Copy Markdown
Author

Thank you for reviewing my PR

@illicitonion

illicitonion commented Aug 24, 2026

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Luro91 Luro91 Luro91 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shehu-dona @Luro91 @illicitonion @dona-shehu