Manchester | 26-ITP-May | John Robinson | Sprint 2 | Coursework - #1495
Manchester | 26-ITP-May | John Robinson | Sprint 2 | Coursework#1495JohnRob-jnr wants to merge 2 commits into
Conversation
JohnRob-jnr
added
📅 Sprint 2
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, and well done for trying the stretch task. I have a question about the stretch task tests.
| console.assert( | ||
| currentOutput4 === targetOutput4, | ||
| `current output: ${currentOutput4}, target output: ${targetOutput4}` | ||
| ); No newline at end of file |
There was a problem hiding this comment.
With testing the goal is to ensure all branches of code are tested. Are all the main edge cases covered by your tests?
There was a problem hiding this comment.
Thanks for the feedback, would I be right in thinking that 24:00 was a missing test? I have added this & done the pull request
LonMcGregor
added
Reviewed
JohnRob-jnr
added
the
Needs Review
|
The change you have made kind of fixes it, because now all the branches are tested, and 2400 is possibly a time you could have input. My original comment was more about the fact that you didn't have a test for hours at 00. But the task is done now, good work |
LonMcGregor
added
Complete
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
3 participants
Self checklist
Changelist
Submission of coursework for Sprint 2