London | 26-ITP-May | Jorvan White | Sprint 3 | Practice TDD - #1602
Closed
JorvanW wants to merge 37 commits into
Closed
London | 26-ITP-May | Jorvan White | Sprint 3 | Practice TDD#1602JorvanW wants to merge 37 commits into
JorvanW wants to merge 37 commits into
Conversation
There was a problem hiding this comment.
if the question requires to also handle 2nd and 3rd etc, then there will be more test cases.
Comment on lines
+2
to
+3
| if (times === 0) { | ||
| return ""; |
There was a problem hiding this comment.
How about empty string (with the same set of counts 3, 1, 0, -1)?
hackertainment
left a comment
hackertainment
left a comment
There was a problem hiding this comment.
You basically got the right direction. Good work, and keep it up :-)
hackertainment
added
Reviewed
JorvanW
added
Needs Review
hackertainment
added
Review in progress
Author
|
Hello, is this completed or is there anything else I need to change. Many Thanks. |
Only needd to address these two issues. Thank you.
|
Author
|
made changes and added more test cases. |
JorvanW
added
Needs Review
hackertainment
added
Complete
Member
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Created Pull Request from Sprint 3 Task and updated for Pull Request