Add CLEAR_ASSET_CACHE_ON_STATE_SWITCH - #1083
Open
HEIHUAa wants to merge 1 commit into
Open
Conversation
r6915ee
reviewed
Aug 22, 2026
Comment on lines
+57
to
+61
| for (key in [for (k in FlxG.bitmap._cache.keys()) k]) { | ||
| var graphic = FlxG.bitmap._cache.get(key); | ||
| if (graphic != null && graphic.assetsKey != null) | ||
| FlxG.bitmap.removeByKey(key); | ||
| } |
Contributor
There was a problem hiding this comment.
Unless this doesn't work as intended, wouldn't it be simpler and slightly more optimal to iterate over the actual FlxGraphic objects instead and fetch the key from there? The FlxGraphic.key field should already point to the actual cache key.
Contributor
Author
There was a problem hiding this comment.
That makes sense. When I wrote that code, I wasn't actually focusing on that — instead, I was focused on figuring out how to clear the shader cache with a single button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since directly modifying the State reset might not be appropriate last time, I've changed it to add a new parameter CLEAR_ASSET_CACHE_ON_STATE_SWITCH in Flags to control whether to clear all caches when switching States. During mod development, it is necessary to update assets in real time.