added workflow template service #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colstuwjx
requested changes
Oct 22, 2021
There was a problem hiding this comment.
Could you fillout the workflow job template mock data under mockdata dir, from now, it can't pass the tests ( For background: I'm using travis CI previously, but it didn't work anymore, we need to migrate to GitHub Actions to enable the CI tests...):
➜ awx-go git:(feature/workflowtemplates) make test
go: downloading github.com/kylelemons/godebug v1.1.0
go get: upgraded github.com/kylelemons/godebug v0.0.0-20170820004349-d65d576e9348 => v1.1.0
>> running all tests
# github.com/Colstuwjx/awx-go [github.com/Colstuwjx/awx-go.test]
./workflow_template_test.go:180:5: unknown field 'UnifiedWorkflowJobTemplate' in struct literal of type Related
./workflow_template_test.go:186:5: unknown field 'WorkflowJobTemplate' in struct literal of type Related
./workflow_template_test.go:193:5: unknown field 'WorkflowJobTemplate' in struct literal of type Summary
./workflow_template_test.go:223:5: unknown field 'UnifiedWorkflowJobTemplate' in struct literal of type Summary
./workflow_template_test.go:300:4: unknown field 'UnifiedWorkflowJobTemplate' in struct literal of type WorkflowJobLaunch
./workflow_template_test.go:314:4: unknown field 'WorkflowJobTemplate' in struct literal of type WorkflowJobLaunch
./workflow_template_test.go:460:4: unknown field 'JobType' in struct literal of type WorkflowJobTemplate
./workflow_template_test.go:462:4: unknown field 'Project' in struct literal of type WorkflowJobTemplate
./workflow_template_test.go:463:4: unknown field 'Playbook' in struct literal of type WorkflowJobTemplate
./workflow_template_test.go:464:4: unknown field 'Forks' in struct literal of type WorkflowJobTemplate
./workflow_template_test.go:464:4: too many errors
FAIL github.com/Colstuwjx/awx-go [build failed]
? github.com/Colstuwjx/awx-go/awxtesting/mockserver [no test files]
? github.com/Colstuwjx/awx-go/awxtesting/mockserver/mockdata [no test files]
FAIL
make: *** [test] Error 2
Thanks!
Co-authored-by: Jacky Wu <Colstuwjx@gmail.com>
…89/awx-go into feature/workflowtemplates
|
Working on test for wkflowtemplates, just need to find a good api response from awx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for WorkflowJob Templates