Fix undefined behavior when getting the current working directory from std::filesystem #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HubLot
approved these changes
Oct 17, 2024
al42and
reviewed
Oct 17, 2024
|
|
||
| // Legacy code | ||
| size_t constexpr buf_size = 3001; | ||
| std::string cwd; |
| @@ -38,6 +38,12 @@ class colvarproxy_io { | |||
| // Returns error code | |||
| virtual int set_frame(long int); | |||
|
|
|||
| /// Get the current working directory of this process | |||
| virtual std::string get_current_work_dir() const; | |||
There was a problem hiding this comment.
Does it need to be virtual? I think it can even be static.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two functions
colvarproxy_io::get_current_work_dir()andcolvarproxy_io::join_paths()to replace the code currently used incolvarbias_meta.cpp. It's possible that these may be removed again sometime in the future.Fixes #726