Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DX: workflows including MyST NB and precommit added #9
DX: workflows including MyST NB and precommit added #9
Changes from 17 commits
59c5d0e
5f8e719
3db9430
3113f6d
94325bb
99c3c8f
cf5c872
16b4281
e9965c1
8c7ae76
07b7af4
8ac9e0a
9322e7f
e30f2d4
4aee62a
5dbf6b8
3bb82ba
7e3a2e3
f6b2f1f
ce30fbe
791a98a
a4c9277
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not needed. Never used it for any other ComPWA project and those work just fine.
For sure it's not needed in the
build
step 😅There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But seems like this is working fine too. I think I'll keep it for https://pages.github.com/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building the pages with
pixi run doc
is still missing here. That's also what thewith.path
was originally for (notsetup-pixi
, that requires no arguments).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually https://github.com/actions/upload-pages-artifact is also missing. That is where
with.path
should be used.Example here:
https://github.com/RUB-EP1/amplitude-serialization/blob/c1451c9f33d126a86106e306f9ab595bd52c7516/.github/workflows/docs.yml#L39-L43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok this is now added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Done
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to leave out
version
anddescription
for now. They're optionalhttps://pixi.sh/latest/reference/configuration/#version-optional