use calldata array lengths directly

Consensys · Oct 25, 2024 · 8bf9d86 · 8bf9d86
1 parent 3432687
commit 8bf9d86
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/contracts/contracts/lib/PauseManager.sol b/contracts/contracts/lib/PauseManager.sol
@@ -60,13 +60,12 @@ abstract contract PauseManager is Initializable, IPauseManager, AccessControlUpg
     PauseTypeRole[] calldata _pauseTypeRoleAssignments,
     PauseTypeRole[] calldata _unpauseTypeRoleAssignments
   ) internal onlyInitializing {
-    uint256 arrayLength = _pauseTypeRoleAssignments.length;
-    for (uint256 i; i < arrayLength; i++) {
+    for (uint256 i; i < _pauseTypeRoleAssignments.length; i++) {
       _pauseTypeRoles[_pauseTypeRoleAssignments[i].pauseType] = _pauseTypeRoleAssignments[i].role;
       emit PauseTypeRoleSet(_pauseTypeRoleAssignments[i].pauseType, _pauseTypeRoleAssignments[i].role);
     }
-    arrayLength = _unpauseTypeRoleAssignments.length;
-    for (uint256 i; i < arrayLength; i++) {
+
+    for (uint256 i; i < _unpauseTypeRoleAssignments.length; i++) {
       _unPauseTypeRoles[_unpauseTypeRoleAssignments[i].pauseType] = _unpauseTypeRoleAssignments[i].role;
       emit UnPauseTypeRoleSet(_unpauseTypeRoleAssignments[i].pauseType, _unpauseTypeRoleAssignments[i].role);
     }

diff --git a/contracts/contracts/lib/PermissionsManager.sol b/contracts/contracts/lib/PermissionsManager.sol
@@ -17,9 +17,7 @@ abstract contract PermissionsManager is Initializable, AccessControlUpgradeable,
    * @param _roleAddresses The list of addresses and roles to assign permissions to.
    */
   function __Permissions_init(RoleAddress[] calldata _roleAddresses) internal onlyInitializing {
-    uint256 roleAddressesLength = _roleAddresses.length;
-
-    for (uint256 i; i < roleAddressesLength; i++) {
+    for (uint256 i; i < _roleAddresses.length; i++) {
       if (_roleAddresses[i].addressWithRole == address(0)) {
         revert ZeroAddressNotAllowed();
       }