Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover/constraint for the update operation #149

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

arijitdutta67
Copy link
Contributor

This PR adds the following constraint for the update operation:

  1. For Update operation, HKey remains the same

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.54%. Comparing base (4f4be57) to head (7dc3dee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #149      +/-   ##
============================================
- Coverage     71.61%   71.54%   -0.08%     
  Complexity     1084     1084              
============================================
  Files           299      299              
  Lines         12145    12114      -31     
  Branches       1135     1077      -58     
============================================
- Hits           8698     8667      -31     
  Misses         2956     2956              
  Partials        491      491              
Flag Coverage Δ *Carryforward flag
hardhat 98.63% <ø> (-0.05%) ⬇️ Carriedforward from 2986d31
kotlin 69.43% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

see 3 files with indirect coverage changes

@arijitdutta67 arijitdutta67 self-assigned this Oct 8, 2024
@arijitdutta67 arijitdutta67 marked this pull request as ready for review October 8, 2024 07:47
@arijitdutta67 arijitdutta67 added the Prover Tag to use for all work impacting the prover label Oct 17, 2024
@AlexandreBelling AlexandreBelling merged commit 333adfc into main Oct 25, 2024
2 of 4 checks passed
@AlexandreBelling AlexandreBelling deleted the prover/update-hkey-constraint branch October 25, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants