smart-contract V6 review small tweaks #207
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Since we are making a change & audit, maybe it's a good opportunity to assess the following points
Other Improvement Suggestions
Blob Submission
Current Interface
The list of SupportingSubmissionDataV2 has redundant fields (first/final)BlockInData, because
_blobSubmissionData[i].subissionData.firstBlockInData
must be equal to its ancestor_blobSubmissionData[i-1].subissionData.finalBlockInData
;We can keep just finalBlockInData and pass only firstBlockInData for the first bock in
submitBlobs(..)
. SupportingSubmissionDataV2’s fields can be included in the parent struct BlobSubmissionData.This simplification will:
SubmissionDataV2
struct used for blob submission as call data;_validateSubmissionData
, potentially saving more gas;New Interface Suggestion
Block Finalization
_computeLastFinalizedState
relies on "timestamp The final timestamp in the finalization.", should it use finalStateRootHash? Sequencer(s) can have different blocks at same timestamp.