fixed the bug in PolyEval #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soleimani193
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
=========================================
Coverage 70.57% 70.57%
Complexity 1059 1059
=========================================
Files 291 291
Lines 11960 11960
Branches 1103 1103
=========================================
Hits 8441 8441
Misses 3039 3039
Partials 480 480
|
Soleimani193
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Soleimani193
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Soleimani193
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
AlexandreBelling
previously approved these changes
Oct 21, 2024
gusiri
previously approved these changes
Oct 21, 2024
Soleimani193
dismissed stale reviews from gusiri and AlexandreBelling
via
489f52e
Soleimani193
force-pushed
the
prover/fix-PolyEval-over-Product
branch
from
f3678e6
to
489f52e
Compare
Soleimani193
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
gusiri
approved these changes
Oct 22, 2024
arijitdutta67
approved these changes
Oct 22, 2024
AlexandreBelling
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue #192 for the case of PolyEval over Product and also PolyEval over PolyEval happening in the inner-product compiler and selfrecursion. For the product operator Product.Evaluate() outputs *Pooled type that was not supported as input to PolyEval.
close #192
Checklist