Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compare initial and final values #219

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Oct 21, 2024

  • Fix a bug where no comparison between initial and final values of execution public input was being performed.
  • Implement the "rollingHash = 0 implies no update" logic.
  • Reduce the runtime of PI circuit tests by running 16 instances instead of 84 and mocking keccak wizard verification.

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully run tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.57%. Comparing base (333bc77) to head (dfd0487).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #219   +/-   ##
=========================================
  Coverage     70.57%   70.57%           
  Complexity     1059     1059           
=========================================
  Files           291      291           
  Lines         11960    11960           
  Branches       1103     1103           
=========================================
  Hits           8441     8441           
  Misses         3039     3039           
  Partials        480      480           
Flag Coverage Δ
hardhat 98.67% <ø> (ø)
kotlin 68.26% <ø> (ø)

Copy link
Contributor

@gusiri gusiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexandreBelling AlexandreBelling merged commit 7a4d510 into main Oct 22, 2024
15 of 16 checks passed
@AlexandreBelling AlexandreBelling deleted the feat/prover/cmp-rollinghash branch October 22, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants