Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import message log based on Elasticsearch. #2583

Merged
merged 6 commits into from
Aug 19, 2019

Conversation

MichaelRitzert
Copy link
Contributor

#2579
I folded the view, model and widget into one plugin, but kept the ES client separate since I require this also in other code.

@MichaelRitzert
Copy link
Contributor Author

It seems there is a problem with the dependencies on org.csstudio.apputil.

@MichaelRitzert
Copy link
Contributor Author

Can I please get a review for this?

@kasemir
Copy link
Contributor

kasemir commented Jun 11, 2019

Sorry, haven't been involved in this, but as far as I can tell this is about sending the log messages to ES and having a message viewer for it. Shouldn't affect those who don't want to use it.
But there's the build errors, and since this PR was created, the build settings have been changed in the process of moving to Java 9/10/11/12. So before merging it, I think we need to get the build to pass.
Last error I saw was basically The job exceeded the maximum time limit for jobs, and has been terminated., so I've started the build again.

@MichaelRitzert
Copy link
Contributor Author

Still no luck, it seems.

Note: I will create another pull request to master which uses java.net.http and javax.json (which is probably a problem now…), once the build is stable for master. But I will also need this version of code in 4.5.

@MichaelRitzert
Copy link
Contributor Author

Is there anything I can do to get this accepted? The last "error" was "The job exceeded the maximum time limit for jobs, and has been terminated."

@berryma4
Copy link
Member

berryma4 commented Aug 16, 2019 via email

@berryma4 berryma4 self-requested a review August 19, 2019 19:49
@berryma4 berryma4 merged commit 0bb0a83 into ControlSystemStudio:4.5.x Aug 19, 2019
@MichaelRitzert
Copy link
Contributor Author

Thank you. With the structure of the code settled, I will prepare the corresponding request for master.

@MichaelRitzert MichaelRitzert deleted the issue/2579 branch August 20, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants