[codeathon]Fix errors on javadoc generation on core-framework #2795 #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tynanford
reviewed
Sep 1, 2023
| /** | ||
| * Constructor | ||
| */ | ||
| public ACos() |
There was a problem hiding this comment.
@abrahamwolk comment from previous PR still applies here and a few other spots
georgweiss
reviewed
Sep 1, 2023
There was a problem hiding this comment.
Not sure how to review. Enabling javadoc lint (disabled by default) still generates errors.
@tynanford has a point in this is work in progress, so I do not mind a merge.
Hie, actually, I commit module by module, there is still 5 modules in core that generates javadoc error. And the module in app also in errors. Today, I'm trying to finish all, I will make my pull request at the end that enscope severals commit. Katy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.