Tank: 'Horizontal' widget used space of 'vertical' #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the way the widget was rotated, it would capture mouse clicks as if it was in the default, vertical orientation, ignoring the transformation that makes it appear horizontally. This might be a JavaFX error, but nevertheless prevented interacting with widgets that are 'below' the horizontal tank. Fixed by transforming the tank inside the pane instead of transforming the pane.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tanviash provided an example display with a problem in the tank widget when in 'horizontal' mode.
Because of the way the widget was rotated, it would capture mouse clicks as if it was in the default, vertical orientation, ignoring the transformation that makes it appear horizontally.
For the attached display, trying to click on the Text Entry that's shown selected in the screenshot was impossible because the mouse click was captured by the tank widget that's shown above:
This might be a JavaFX error, but nevertheless prevented interacting with widgets that are 'below' the horizontal tank. Fixed by transforming the tank inside the pane instead of transforming the pane.
BrokenTank.txt