Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSTUDIO-1903 Bugfix: Set colors using CSS when alarm_table_color_legacy_background enabled #2813

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

kasemir
Copy link
Collaborator

@kasemir kasemir commented Sep 8, 2023

See screenshots in comments for color handling update #2642

…s.applications.alarm/alarm_table_color_legacy_background is set to "true".
@abrahamwolk
Copy link
Collaborator

When org.phoebus.applications.alarm/alarm_table_color_legacy_background == false, there is a (transparent?) margin of 2 pixels above and below the background color: the result is that it is easy, in the vertical direction, to see the borders between the individual cells displaying severity levels.

In contrast, when org.phoebus.applications.alarm/alarm_table_color_legacy_background == true (the case that this PR affects), there is no margin around the background of cells in the severity columns. The consequence is that when the severity level of two vertically adjacent cells are the same, one cannot see where one cell ends and another cell begins in the vertical direction without comparing with adjacent columns.

Should this be changed?

@kasemir
Copy link
Collaborator Author

kasemir commented Sep 11, 2023

Can you easily add the 2 px margin? That would of course look a little better.

@kasemir
Copy link
Collaborator Author

kasemir commented Sep 11, 2023

Otherwise, it "works" well. I've had the old and patched version run over the weekend, and the patch indeed fixes the problem, no more missing colors.

@abrahamwolk
Copy link
Collaborator

It's very easy to add them. I have added them now.

@kasemir
Copy link
Collaborator Author

kasemir commented Sep 11, 2023

Perfect, thanks!

@kasemir kasemir merged commit d6d1350 into master Sep 11, 2023
2 checks passed
@kasemir kasemir deleted the CSSTUDIO-1903-bugfix branch September 11, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants