Skip to content

Commit

Permalink
Extra docs and annotations
Browse files Browse the repository at this point in the history
  • Loading branch information
mikera committed Aug 27, 2024
1 parent f2c6663 commit 16d1012
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 2 deletions.
4 changes: 3 additions & 1 deletion convex-cli/src/main/java/convex/cli/Main.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@

/**
* Convex CLI implementation
*
* This is the main `convex` command and root for child commands.
*/
@Command(name = "convex",
subcommands = { Account.class, Key.class, Local.class, Peer.class, Query.class, Status.class, Desktop.class,
Expand Down Expand Up @@ -161,7 +163,7 @@ private void setupVerbosity() {
/**
* Version provider class
*/
public static final class VersionProvider implements IVersionProvider {
private static final class VersionProvider implements IVersionProvider {
@Override
public String[] getVersion() throws Exception {
String s = Main.class.getPackage().getImplementationVersion();
Expand Down
1 change: 1 addition & 0 deletions convex-core/src/main/java/convex/core/data/Syntax.java
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ private Syntax(Ref<ACell> datumRef, AHashMap<ACell, ACell> props) {
this.meta = props;
}

@Override
public AType getType() {
return Types.SYNTAX;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ public abstract class ANumeric extends APrimitive implements Comparable<ANumeric
*/
public abstract CVMDouble toDouble();

@Override
public abstract double doubleValue();

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
/**
* Abstract base class for CVM primitive values.
*
* We don't use JVM primitives directly in CVM data structures because these primitives need to inherit
* the basic ACell functionality, but these are otherwise relatively lightweight wrappers over the
* underlying JVM types.
*
*/
public abstract class APrimitive extends ACell {
@Override
Expand Down Expand Up @@ -34,7 +38,7 @@ protected long calcMemorySize() {
}

/**
* @return Java long value representing this primitive CVM value
* @return Java long value representing this primitive CVM value. Essentially equivalent to JVM cast.
*/
public abstract long longValue();

Expand Down

0 comments on commit 16d1012

Please sign in to comment.