Fugacity functions update #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chris-hampel-CA can you please check if this is OK? If so we can merge and release a new CoolProp.jl version. |
src/CoolProp.jl
Outdated
| julia> AbstractState_free(handle); | ||
| ``` | ||
| """ | ||
| function AbstractState_get_fugacity_coefficient(handle::Clong, i::Integer) #TODO: maybe type this as an integer? |
There was a problem hiding this comment.
remove TODO comment
src/CoolProp.jl
Outdated
| @@ -926,6 +926,63 @@ function AbstractState_update(handle::Clong, input_pair::AbstractString, value1: | |||
| return nothing | |||
| end | |||
|
|
|||
| #TODO: these functions will not work with CoolProp_jll 6.5. Needs new version released of current master from Sept 2023 | |||
There was a problem hiding this comment.
remove TODO comment
|
Hi @barche Looks good to me. You can double check by looking at the output of the example fugacity calls in the A couple comments should be removed that I called out, however. Also, I noticed a few other changes in the Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase and update of PR #33