Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simple_offboard: Relax position_msg timestamp update rules #264

Merged
merged 2 commits into from
Aug 4, 2020
Merged

simple_offboard: Relax position_msg timestamp update rules #264

merged 2 commits into from
Aug 4, 2020

Conversation

sfalexrog
Copy link
Member

position_msg's timestamp is not updated if the setpoint type is YAW_RATE. This may result in nav_start not having a proper timestamp, which, in turn, would result in incorrect getNavigateSetpoint behavior.

This P/R addresses the issue.

@okalachev
Copy link
Member

I'll examine this today or tomorrow.

@okalachev
Copy link
Member

okalachev commented Aug 4, 2020 •
edited
Loading

It would be really nice if we had tests on this, BTW (#151).

@okalachev okalachev merged commit 17c2109 into master Aug 4, 2020
@okalachev okalachev deleted the simple_offboard_timestamp branch October 23, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okalachev okalachev Awaiting requested review from okalachev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfalexrog @okalachev