Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for Touch event before closing menu #1305

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

ConfusedVorlon
Copy link
Contributor

Under catalyst, as you move the mouse around, it hit tests with UIHoverEvent

these currently trigger closing the menu before you're able to move the mouse up to actually click on anything

we could test explicitly for .hover events and ignore them, but they're not available in earlier versions of iOS, so it's easier to just check for .touches events. This also means that shake, remote control events, etc won't close the menu (though I don't know if they trigger a hit test anyway)

@ConfusedVorlon
Copy link
Contributor Author

Hi folks - any thoughts on this?

@ConfusedVorlon
Copy link
Contributor Author

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant