Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log in feature #6

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Log in feature #6

wants to merge 17 commits into from

Conversation

Odeane
Copy link

@Odeane Odeane commented Jun 25, 2020 •
edited
Loading

PT board URL

User Story

As a user
In order to send messages
I want to be able to log in.

Changes proposed in this pull request:

  • Using factory robot to create a user
  • entered email address
  • Entered password
  • sad path testing

What I have learned working on this feature:

  • We learn how to create a 'decoy' with factory bot.
  • Adding testing frameworks.
  • Testing for features with rspec

Packages/Gems added

  • capybara
  • rspec rails
  • shoulda-matchers
  • factory bot rails
  • coveralls

Odeane and others added 14 commits June 24, 2020 15:27
@Odeane
fixing gem bug, creating rspec folder and creating db migration to co…
6913aac 
…rrect format
@Alex-Bellamy
installing Rspec, creating a database, updating migration version, ap…
c1720bd 
…p now loads on server
created a specfolder and updated the db migration version to 4.2 and …
76f7174 
…created a db migartion for add_missing_indices.mailboxer_engine
@Alex-Bellamy
login functionality - adding test to ensure Login button is present a…
2583dc9 
…nd the button functions which pass
wrote teo new tests for log in feature, first i changed root_path to …
2368b8d 
…user_session_path then wrote test to locate Email to make sure i was in the right path second test was for filling in email, password and then clickon log in button
writing test for redirecting efter log in
62fbc43
updated README
d3d1558
@Odeane
testing setup
83b73b6
@Odeane
setting up factor bot, adding shoulder matcher
d909ed5
@Alex-Bellamy
Merge branch 'log_in_feature' of https://github.com/Odeane/legacy_cod…
02562d0 
…e_june_2020
@Alex-Bellamy
amending Factorybot password to enable tests to pass
e637ffb
rewrote test to actually display that the login was succsessful
a38bda3
@Odeane
sad path for not entering or entering incorrect password
4dab8ae
@Odeane
adding coveralls
b2da6c7
@Odeane Odeane changed the title Log in feature VIP Log in feature Jun 25, 2020
@Odeane Odeane changed the title VIP Log in feature Log in feature Jun 25, 2020
emtalen
emtalen requested changes Jun 25, 2020
View reviewed changes
Copy link

@emtalen emtalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good jobb overall, look over the formatting! And rewrite the sad path to a more realistic scenario, that a user puts in the wrong password for example.

.rspec Show resolved Hide resolved
Gemfile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
spec/factories/user.rb Show resolved Hide resolved
spec/feature/user_can_log_in_feature_spec.rb Show resolved Hide resolved
spec/feature/user_can_log_in_feature_spec.rb Show resolved Hide resolved
spec/models/user_spec.rb Show resolved Hide resolved
spec/user_can_log_in_spec.rb
end
end


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file if you are not using it.

spec/feature/user_can_log_in_feature_spec.rb Outdated Show resolved Hide resolved
emtalen
emtalen requested changes Jun 26, 2020
View reviewed changes
Copy link

@emtalen emtalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have some formatting to do, I recommend that you install a Ruby formatter so you can have a shortcut to formatting. I use Solargraph but you guys can just search for a formatter in the extensions to find one you like

spec/feature/user_can_log_in_feature_spec.rb Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emtalen emtalen emtalen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Odeane @emtalen @Alex-Bellamy