Address Static Code Analysis issues

CycloneDX · Apr 23, 2023 · a7876a1 · a7876a1
1 parent 89980d7
commit a7876a1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/CycloneDX.Core/Models/Component.cs b/src/CycloneDX.Core/Models/Component.cs
@@ -131,7 +131,7 @@ public ComponentScope NonNullableScope
         [ProtoMember(12)]
         public List<Hash> Hashes { get; set; }
 
-        [XmlIgnore()]
+        [XmlIgnore]
         [ProtoMember(13)]
         public List<LicenseChoice> Licenses { get; set; }
 

diff --git a/src/CycloneDX.Core/Models/LicenseChoice.cs b/src/CycloneDX.Core/Models/LicenseChoice.cs
@@ -46,7 +46,7 @@ public LicenseChoiceList(List<LicenseChoice> licenses)
 
         public LicenseChoiceList() { }
 
-        public List<LicenseChoice> Licenses;
+        public List<LicenseChoice> Licenses { get; set; }
 
         public System.Xml.Schema.XmlSchema GetSchema()
         {

diff --git a/src/CycloneDX.Core/Xml/Serializer.Serialization.cs b/src/CycloneDX.Core/Xml/Serializer.Serialization.cs
@@ -83,7 +83,7 @@ private static XmlSerializer GetXmlSerializer(SpecificationVersion specification
 
         // Todo: this is a workaround to set the set the correct namespace
         // when writing licenses. Can this be avoided?
-        public static Dictionary<XmlWriter,string> WriterToNamespace = new Dictionary<XmlWriter, string>();
+        public readonly static Dictionary<XmlWriter,string> WriterToNamespace = new Dictionary<XmlWriter, string>();
 
         /// <summary>
         /// Serializes a CycloneDX BOM writing the output to a stream.