Fix mangling of plugin_globals with GCC's C++11 ABI
#3612
Conversation
library/include/PluginManager.h
Outdated
| DFhackDataExport const char * plugin_name = m_plugin_name;\ | ||
| DFhackDataExport const char * plugin_version = DFHack::Version::dfhack_version();\ | ||
| DFhackDataExport const char * plugin_git_description = DFHack::Version::git_description();\ | ||
| DFhackDataExport int plugin_abi_version = DFHack::Version::dfhack_abi_version();\ | ||
| DFhackDataExport DFHack::Plugin *plugin_self = NULL;\ | ||
| std::vector<std::string> _plugin_globals;\ | ||
| DFhackDataExport std::vector<std::string> _plugin_globals;\ |
There was a problem hiding this comment.
do we need to export the underscore non-pointer version? is _plugin_globals referenced outside the plugin? I would think we'd only need the extern "C" change and not this export line.
There was a problem hiding this comment.
This line was left over from testing... you are probably right that this one doesn't need to be exported.
There was a problem hiding this comment.
unresolved external symbol _plugin_globals -- might be fixed by reverting that line
There was a problem hiding this comment.
Yeah, pushing up a new version. I'm also going to switch away from the _ prefix, since that's reserved, and C globals actually get a _ prefix added so I'm not sure if that was potentially problematic.
There was a problem hiding this comment.
Built successfully this time!
Without being declared with `extern "C"`, `plugin_globals` is mangled, with a `cxx11` suffix. We can't add `extern "C"` to the `DFhackDataExport` macro because GCC does not allow initializing any `extern` variables inline, including `extern "C"`.
lethosor
force-pushed
the
fix-linux-plugins-cxx11abi
branch
from
b5df3d5
to
73f9620
Compare
Without being declared with
extern "C",plugin_globalsis mangled, with acxx11suffix.We can't add
extern "C"to theDFhackDataExportmacro because GCC does not allow initializing anyexternvariables inline, includingextern "C".