Refactor/widgets #4955
Refactor/widgets #4955
Conversation
ResizingPanel, Pages, EditField, HotkeyLabel, Label and Scrollbar
WrappedLabel, TooltipLabel, HelpButton, ConfigureButton, BannerPanel
TextButton, CycleHotkeyLabel, ButtonGroup, ToggleHotkeyLabel, List
FilteredList, TabBar, Tab, RangeSlider, DimensionsTooltip
| DOUBLE_CLICK_MS = Panel.DOUBLE_CLICK_MS | ||
| STANDARDSCROLL = Scrollbar.STANDARDSCROLL | ||
| SCROLL_INITIAL_DELAY_MS = Scrollbar.SCROLL_INITIAL_DELAY_MS | ||
| SCROLL_DELAY_MS = Scrollbar.SCROLL_DELAY_MS |
There was a problem hiding this comment.
we'll probably need a function-based API for these config elements. As written, if you change these values via the control panel, the relevant widgets won't actually see the changed value and will not change their behavior. See scripts/internal/control-panel/registry.lua for how these values are interacted with.
We could change them to a function interface, like we did for HIDE_ARMOK_TOOLS in dfhack.lua. It is now wrapped with getMortalMode() and setMortalMode() functions. The code in the control panel registry would then have switch to call the new API instead of setting the values directly (this is not hard -- see how the mortal mode functions are called).
There was a problem hiding this comment.
I'm not sure TabBar should be classified as a container. It's meant to be used alongside a container, like a Pages widget, but it doesn't contain other widgets itself.
There was a problem hiding this comment.
moved to root widgets dir
library/lua/gui/widgets.lua
Outdated
| parse_label_text = Label.parse_label_text | ||
| render_text = Label.render_text | ||
| check_text_keys = Label.check_text_keys |
There was a problem hiding this comment.
are there any existing usages of these three functions (parse_label_text, render_text, and check_text_keys)? they aren't really intended for public use. they could probably stay as an internal API and not be exposed in widgets
There was a problem hiding this comment.
you are right.
removed from the public API.
Refactor massive
widgets.luainto module per component style.No API or logic has been changed (at least intentionally).
This is a preparation to add
TextArea(gui/journalstyle input widget) and migrateTextFieldwidget to journal style features.