Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenable forceequip #4979

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

reenable forceequip #4979

wants to merge 3 commits into from

Conversation

ab9rf
Copy link
Member

@ab9rf ab9rf commented Oct 4, 2024

Looked into this based on discord discussion, determined that the code compiles if adjusted to comport with @Bumber64's changes from #4824 so the question at this point is whether it works which I don't have enough information to evaluate

remove `using namespace std`
remove references to MapCache and related
switched to using debug facility instead of `Core::print`/`Core::printerr`

may need further tweaking
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember also to add a line to New Tools in the changelog and update forceequip.rst (at least the tags, which should no longer be "unavailable")

Tags in the spreadsheet are:

adventure fort animals items military units

but that classification might need updating. is animals actually appropriate?

edit: oh, I see. it's because it can be used to put armor onto war animals

@ab9rf
Copy link
Member Author

ab9rf commented Oct 5, 2024

yeah i was holding off on the administrivia until i get some intel that this actually works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review In Progress
Development

Successfully merging this pull request may close these issues.

2 participants